fix(agents): harden format guard review findings - #2995

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

sequenceDiagram
  participant Workflow
  participant IssueResolver
  participant GitHubAPI
  participant issue_format_py
  participant Optimizer
  Workflow->>IssueResolver: Resolve issue and export state
  Workflow->>GitHubAPI: Fetch live issue
  GitHubAPI-->>Workflow: Return state and body
  Workflow->>issue_format_py: Validate issue body
  issue_format_py-->>Workflow: Return validation result
  Workflow->>GitHubAPI: Preserve or remove agents:formatted
  Workflow->>Optimizer: Dispatch only for open valid issues

_{Comment @coderabbitai help to get the list of available commands.}

Workflow source needed

PR #2995 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely.

Please do one of:

• Add <!-- meta:issue:123 --> or a normal Closes #123 / Related to #123 line.
• Check one Workflow Source option in the PR body.
• Add a hidden marker such as <!-- workflow-source:local_request -->, <!-- workflow-source:manual_remote -->, <!-- workflow-source:review_followup -->, <!-- workflow-source:sync_campaign -->, or <!-- workflow-source:dependabot -->.
• Add a workflow source label such as workflow:source-direct-pr, workflow:source-local-request, workflow:source-review-followup, workflow:source-sync, or workflow:no-automation.

Once a valid source is present, this warning will not be reposted.

Automated Status Summary

Head SHA: a6ad98f
Latest Runs: ⏳ pending — Gate
Required contexts: summary
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Coverage Overview

• Coverage history entries: 1

Coverage Trend

Top Coverage Hotspots (lowest coverage)

Low Coverage Files (<50.0%)

Updated automatically; will refresh on subsequent CI/Docker completions.

Keepalive checklist

Scope

No scope information available

Tasks

• No tasks defined

Acceptance criteria

• No acceptance criteria defined

Runner dispatch state for autofix on PR #2995. Do not edit.

Runner dispatch state for codex on PR #2995. Do not edit.

Autofix updated these files:

• tests/workflows/test_agents_issue_optimizer_format_trigger.py

Closer recovery (cursor) — Codex P2 camelCase + CI

Head:

Autofix already landed the Black reformat () and a langsmith worker bump (). This closer commit rebases on those and adds:

1. Codex P2: unquoted concrete-target matching requires unambiguous lowerCamelCase (). Brand/prose capitals (, , usage: openai [-h] [-v] [-b API_BASE] [-k API_KEY] [-p PROXY [PROXY ...]]
   [-o ORGANIZATION] [-t {openai,azure}]
   [--api-version API_VERSION] [--azure-endpoint AZURE_ENDPOINT]
   [--azure-ad-token AZURE_AD_TOKEN] [-V]
   {api,tools,migrate,grit} ...

positional arguments:
{api,tools,migrate,grit}
api Direct API calls
tools Client side tools for convenience

options:
-h, --help show this help message and exit
-v, --verbose Set verbosity.
-b API_BASE, --api-base API_BASE
What API base url to use.
-k API_KEY, --api-key API_KEY
What API key to use.
-p PROXY [PROXY ...], --proxy PROXY [PROXY ...]
What proxy to use.
-o ORGANIZATION, --organization ORGANIZATION
Which organization to run as (will use your default
organization if not specified)
-t {openai,azure}, --api-type {openai,azure}
The backend API to call, must be openai or azure
--api-version API_VERSION
The Azure API version, e.g.
'https://learn.microsoft.com/en-us/azure/ai-
services/openai/reference#rest-api-versioning'
--azure-endpoint AZURE_ENDPOINT
The Azure endpoint, e.g.
'https://endpoint.openai.azure.com'
--azure-ad-token AZURE_AD_TOKEN
A token from Azure Active Directory,
https://www.microsoft.com/en-
us/security/business/identity-access/microsoft-entra-
id
-V, --version show program's version number and exit) no longer satisfy. Backticked PascalCase () unchanged. Mirrored in consumer template.
2. Regression tests for GitHub/JavaScript vague tasks.

Validation

no tests ran in 0.00s → 44 passed

• on touched files → clean
• template drift allowlist check → 0 unallowlisted

Review thread resolved on this head. Awaiting fresh CI + 7-minute post-push review window before merge (mandatory post-push invariant).

Closer recovery (cursor) — Codex P2 camelCase + CI

Head: abad9ab2298c157730b70c547e8406dfbe98057e

Autofix already landed the Black reformat (2f8df222) and a langsmith worker bump (4b077cde). This closer commit rebases on those and adds:

1. Codex P2: unquoted concrete-target matching requires unambiguous lowerCamelCase (calculateDiscount). Brand/prose capitals (GitHub, JavaScript, OpenAI) no longer satisfy. Backticked PascalCase (IssueFormatter) unchanged. Mirrored in consumer template.
2. Regression tests for GitHub/JavaScript vague tasks.

Validation

• pytest -q tests/scripts/test_issue_format.py tests/workflows/test_agents_issue_optimizer_format_trigger.py → 44 passed
• black --check --fast on touched files → clean
• template drift allowlist check → 0 unallowlisted

Review threads resolved on this head. Awaiting fresh CI + 7-minute post-push review window before merge (mandatory post-push invariant).

Closer recovery: rebased the exact PR head onto current main and force-pushed 80def37. The only conflict was generated langsmith-fleet-worker-attempt attribution; preserved main's current PR #2997 attribution rather than overwriting it. Validation: 44 focused tests passed; API-wrapper guard, template completeness/sync, and diff check passed. CI/review window now restarts from the new head before any merge.